mongo-php-adapter icon indicating copy to clipboard operation
mongo-php-adapter copied to clipboard

MongoClient readPreferenceTags options parameter

Open MarioCuljak opened this issue 2 years ago • 2 comments

Hi, looks like when passing readPreferenceTags as $option parameter to MongoClient is interpreted as string of comma separated values. According to mongoclient.construct it should be array of strings.

Is it possible to support array format for readPreferenceTags?

MarioCuljak avatar May 25 '23 11:05 MarioCuljak

Quoting https://github.com/alcaeus/mongo-php-adapter/pull/290#issuecomment-1030329398:

1.2.2 is the last planned release for this library, and I will only accept fixes for critical bugs (those causing security issues or data loss) from this point onwards.

If you are able to produce a pull request that includes a test for this, I can consider merging it if CI is stable. However, main suggestion would be to realise that the driver API you're relying on hasn't been updated in almost 6 years and was designed with compatibility for MongoDB 3.4. It's dead, Jim.

It's dead, Jim

alcaeus avatar May 26 '23 07:05 alcaeus

Thanks for feedback, I'll try to make PR in following days.

MarioCuljak avatar May 26 '23 07:05 MarioCuljak