Albin Ahlbäck

Hmm, it was more than I remember. There is stuff like ```c _ARB_DEF_CACHED_CONSTANT(static, static, _acb_hypgeom_const_li2, _acb_hypgeom_const_li2_eval) ``` for local functions, and then stuff like ```c ARB_DEF_CACHED_CONSTANT(arb_const_khinchin, arb_const_khinchin_eval) ``` global functions....

I have removed all pragmas, and I have inserted `*-impl.h` for modules that needed it.

I also redefined `ARB_DEF_CACHED_CONSTANT` and friends. I believe I am happy with this.

> Seeing the `-impl.h` headers, I'm unconvinced. > > ... > > Some of the functions that have ended up in `-impl.h` headers seem to be there because the declarations...

> Personally I would macro-fy only the human-readable text description and take the function parameter names as parameters in the macro. I thought about this at first, but this standardizes...

> Isn't `R[1]` ambiguous? Yes, but it will always default to `gens(R, 1)`. > And what about `R[:x]`? It will still work as `VarName` is stricter than `Any`.

Generating some opinions before starting to poke around in the code. Ping @fieker @fingolfin @thofma

I would really be in favor of switching to Doxygen

> Can someone point me to some the advantages of doxygen? (I am just curious, I am sure @alexjbest told me a about them, but I have forgotten) I have...

Here are all the instances I can find: https://github.com/flintlib/flint/actions/runs/17006782978/job/48217495792 https://github.com/flintlib/flint/actions/runs/16720460021/job/47323521714 https://github.com/flintlib/flint/actions/runs/17264574164/job/48993599495 https://github.com/flintlib/flint/actions/runs/18882313196/job/53888512505 https://github.com/flintlib/flint/actions/runs/18984838940/job/54226011237 https://github.com/flintlib/flint/actions/runs/18970263945/job/54176148389 https://github.com/flintlib/flint/actions/runs/18968335803/job/54169886357