Albin Ahlbäck
Albin Ahlbäck
You can check the remaining things by grepping for `\.rows\b`. The two places to fix are in `fmpz_mat.jl` and `nmod_mat.jl`, but they seem pretty unused.
Cool, I'm looking forward to next week!
Hello Jean, and sorry for the delay! Is there anything specific that you'd like to have feedback on?
> Do you think the interface looks OK? Yes, I think it looks very good. > And is the documentation clear enough to follow what's going on? Yes, I think...
After you feel like you've addressed everything, could you squash your commits? Something like 1 to 5 commits, depending on how separate the commits can be made and how much...
Can you make it more clear, or direct me on how to compute theta functions for specific $(a, b)$ (or how to obtain them from `acb_theta_all`)?
I think it would make sense to have both. If the user is only interested in one specific tuple, then perhaps a wrapper for `acb_theta_jet` with this stuff you mention....
Do you have more examples of where it fails to return in a reasonable amount of time? I've not looked into it that much, but `fmpz_factor` also gets stuck (which...
@fredrik-johansson This goes into a broader picture of unused arguments. I am for keeping unused arguments as long as it is kept for consistency and it is highlighted in the...
Yeah, Github was acting up at the time of the release. I'll make a manual upload in a couple of days.