Albert Wang comments

Results 21 comments of


                                            Albert Wang

Why is this statement invalid?（branchlength_label_rounding）

I can't reproduce this. I'm guessing you're getting `Decimal point setting is invalid` from uploading in which case that's an error returned from itol and not this library.

Clarify max body size units and format readme

The issue with `BODY`/`BYTES` was fixed in d40bb9dc. The formatting changes are fine but are separate from what this PR was trying to fix.

Django 4.1 unique constraint failing

Pending #622

Django 4.1 unique constraint failing

No, I don't. I think we should do a release asap.

Max body size units

Fixed in d40bb9dc

feat: delete all requests using raw_delete to avoid memory issues

Is this safe from side effects? According to [documentation](https://github.com/django/django/blob/main/django/db/models/query.py#L1208), `_raw_delete` doesn't support signals and has no protection for cascades. Django-silk doesn't utilize signals (users of django-silk might, though unlikely) but...

`Request.objects.all().delete()` is dangerous

> If you call all() on a table with many rows, it will retrieve all the data at once I don't think that's true. It will retrieve data from the...

`Request.objects.all().delete()` is dangerous

@moonsikpark put up a fix in #712 but it's not mergeable due to tests not passing

Should we consider requirement `autopep8` only as development only?

While in most libraries, `autopep8` is used only in the build/test steps, in django-silk, `autopep8` is used in the production environment https://github.com/albertyw/django-silk/blob/master/silk/code_generation/django_test_client.py which is used to generate test code to...

Conda package not support python 3.12

Django-silk has supported python 3.12 since version [5.1.0](https://github.com/jazzband/django-silk/releases/tag/5.1.0). You probably need to update to a newer version of django-silk