Alberto Sartori

@tsloughter upgraded deps and a failing test, let's if it works now.

Before merging we should choose a good name for the option, in principle it can be added also to other HTTP client/server instrumenters. In js for instance they call it...

@tsloughter ready

Is there something missing to this to be merged?

@bryannaegele perfect thanks! I was just wondering if there was something missing from my side

The specification is very clear, thanks for sharing. I got confused by the HTTP semantic conventions (https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#status) where setting span status to error for codes >= 400 is a MUST

If this is the case (the span can be marked as ok as configured) then we should extend this functionality also to other libs and to 2xx and 3xx status...

Moving here a comment from @tsloughter > Actually, maybe there should be one function that returns whether to create a span and whether to propagate: > > ``` > filter(Req)...

I read it but my understanding of the total order part was "once set to ok the status can't change" not "to set the status to ok it must pass...

I can start with the cowboy and phoenix instrumentation