python icon indicating copy to clipboard operation
python copied to clipboard

Update jetbrains plugin

Open mqus opened this issue 4 years ago • 3 comments

This updates the submodule hash to point to the newest version, which is compatible to v0.4 of the API.

mqus avatar Dec 20 '20 20:12 mqus

Tested locally. Everything is fine. :+1: Good to merge.

tomsquest avatar Jan 12 '21 16:01 tomsquest

Please review @alswl, @barbUK or @bergercookie . This plugin is not working for almost a year now and really needs this update. I was told that making this a submodule would simplify updates but so far this has not worked out at all.

mqus avatar Nov 22 '21 16:11 mqus

Haven't tested it since I don't use jetbrains, but the changes look sensible.

bergercookie avatar Nov 22 '21 16:11 bergercookie

0.18 is out. Please check the new api . Do you mind to volunteer as a maintainer for the plugin?

ManuelSchneid3r avatar Jan 03 '23 19:01 ManuelSchneid3r

See https://github.com/mqus/jetbrains-albert-plugin/pull/5 :)

mqus avatar Jan 07 '23 13:01 mqus

I hope its not too much of a hassle but can you please add without the submodule? Rationale coming asap.

ManuelSchneid3r avatar Jan 07 '23 13:01 ManuelSchneid3r

Rationale

ManuelSchneid3r avatar Jan 07 '23 20:01 ManuelSchneid3r

@mqus do mind to maintain it if I move it in the repo?

ManuelSchneid3r avatar Jan 25 '23 19:01 ManuelSchneid3r

@ManuelSchneid3r I can also step up to maintain it. I did a complete rewrite of the plugin. The PR is on @mqus side on his repo. I think I will submit it here directly if no answer.

tomsquest avatar Jan 26 '23 16:01 tomsquest

@ManuelSchneid3r I can also step up to maintain it. I did a complete rewrite of the plugin. The PR is on @mqus side on his repo. I think I will submit it here directly if no answer.

Actually I'd prefer this because I want jo join the party to get it working on MacOS

ManuelSchneid3r avatar Jan 26 '23 19:01 ManuelSchneid3r

Sorry, IRL stuff. Yes, I'm also in favor of maintaining it here. Let me open a PR.

mqus avatar Jan 27 '23 20:01 mqus