albertlauncher
[remmina] Add Remmina extension
@albertlauncher/python-reviewers is anybody using remmina and can test this?
There's already a Remmina plugin by @okb1100 here:
https://github.com/bergercookie/awesome-albert-plugins/blob/master/plugins/remmina/init.py
Is there a major difference between these two?
https://github.com/bergercookie/awesome-albert-plugins/blob/master/plugins/remmina/init.py
:open_mouth: There's another repo full of plugins?! Maybe it would be better to add them all here? Or at least mention the repo in the documentation?
Is there a major difference between these two?
Yours seems more robust, shows additional info about the connections and reads connections from ~/.local/share/remmina.
Mine shows available connections without the trigger at the start (which I would really prefer) and reads connections from ~/.remmina. Don't know which folder is right, seems like it saves the connections to both.
There's another repo full of plugins?!
Yeah, I had mentioned it in the Telegram chat when I started it but the community wasn't active back then.
Maybe it would be better to add them all here? Or at least mention the repo in the documentation?
Sure, happy to somehow integrate them to the mainline python plugins one way or another.. @ManuelSchneid3r what do you think?
I've left some comments for this PR but I think it would be better to instead make a PR to the awesome-albert-plugins repo with any changes that you want to make to the existing plugin (e.g., the different icons per protocol ;) ). This way we won't have to maintain two different versions that do roughly the same thing.
Yours seems more robust, shows additional info about the connections and reads connections from
~/.local/share/remmina.Mine shows available connections without the trigger at the start (which I would really prefer) and reads connections from
~/.remmina. Don't know which folder is right, seems like it saves the connections to both.
If in doubt, err on the side of the XDG dirs (~/.config, ~/.local/share etc) rather than folders in the homedir which are gradually being phased out by most things.
+1 for merging those other plugins into this repo now that things are more active. For this plugin, a combination of the two would be nice - specifically being able to see the connections without a trigger (similar to how vbox VMs show)
@gentoo90 are you still interested in getting this plugin upstream?
I am going to close this PR. It is not that I dont want this to be shipped upstream, but, as is, it cant be merged due to conflicts. Users/devs get the impression that I dont want to merge plugins, probably simply due to the amount of open PRs. It's cumbersome for me to repeatedly iterate all these abandoned and stale PRs. Note that I am still interested in merging an up to date version of this plugin and I still get notifications. So if you want something to happen leave a comment or simply open a new PR.