albert icon indicating copy to clipboard operation
albert copied to clipboard

[firefox] Seach history

Open ManuelSchneid3r opened this issue 7 years ago • 4 comments

https://github.com/albertlauncher/python/pull/21

to be implemented in c++ to reduce cluttering and keep up UX

ManuelSchneid3r avatar Mar 09 '18 16:03 ManuelSchneid3r

do we have any plan on this?

kaleocheng avatar Mar 18 '20 04:03 kaleocheng

The plan goes something like this:

  • Find a C++ dev who has the time and energy to work on this
  • Let her/him add a second index for the history
  • Let him/her duplicate lines 180~230 of the Firefox extension code and change the code to query the history instead of bookmarks and add them to the newly created second index. The required query would be something like: SELECT MAX(history.id), places.url FROM moz_historyvisits history JOIN moz_places places ON history.place_id = places.id GROUP BY place_id ORDER BY history.id DESC
  • Add a prefix test to the handleQuery method to test against a configurable prefix. On prefix present search the newly created index else search the standard bookmark index

This with the prefix and seperate indices can optionally be left out and combined so that the FF extension always returns both bookmarks and history visits.

The complicated and currently blocking point of that list is actually the first. The rest is easy. It's really not very complicated. But I currently don't have the motivation to do this and no one else (afaik) has worked on this. Actually anyone who would like could give it a try, I'll review it and then I'll merge it into my PR albertlaucher/plugins#30 But I don't want to code it myself right now.

idkCpp avatar Mar 25 '20 16:03 idkCpp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 05 '20 00:11 stale[bot]

Pls reopen. This is an ongoing task related to integrating albertlauncher/plugins/pull/41 in the firefox extension

idkCpp avatar Dec 05 '20 09:12 idkCpp