iTunes-Volume-Control
iTunes-Volume-Control copied to clipboard
alberti42
Play sound if Shift key is pressed
I recently found this project and I'm quite thankful for it! It's been driving me nuts that I can't change the volume of Music going to my HomePod easily using the volume keys on my keyboard. This project has made that possible!
The one feature that I miss, which I use regularly to quickly test that my AirPod Pros are correctly connected to my Mac when I'm doing a video chat, is the ability to hold the Shift key and hear a 'tick' sound. So that's what this PR adds.
I understand. I will have a look if I can restore the tick sound, but I cannot promise it.
On 22. Aug 2020, at 17:06, Paul Marcos [email protected] wrote:
I recently found this project and I'm quite thankful for it! It's been driving me nuts that I can't change the volume of Music going to my HomePod easily using the volume keys on my keyboard. This project has made that possible!
The one feature that I miss, which I use regularly to quickly test that my AirPod Pros are correctly connected to my Mac when I'm doing a video chat, is the ability to hold the Shift key and hear a 'tick' sound. So that's what this PR adds.
You can view, comment on, or merge this pull request online at:
https://github.com/alberti42/iTunes-Volume-Control/pull/30 https://github.com/alberti42/iTunes-Volume-Control/pull/30 Commit Summary
Add the option of playing the same sound that the system does if the Shift key is pressed while changing volume. File Changes
M iTunes Volume Control/AppDelegate.m https://github.com/alberti42/iTunes-Volume-Control/pull/30/files#diff-da0a1c7b1578d2107fe0ac3d24c67366 (23) Patch Links:
https://github.com/alberti42/iTunes-Volume-Control/pull/30.patch https://github.com/alberti42/iTunes-Volume-Control/pull/30.patch https://github.com/alberti42/iTunes-Volume-Control/pull/30.diff https://github.com/alberti42/iTunes-Volume-Control/pull/30.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alberti42/iTunes-Volume-Control/pull/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPC4GQ46KBXCTT5K4SGH3SB7NGNANCNFSM4QIELMFA.
The changes to restore it are included in this PR. I'm running my fork with these changes and it works great, at least for my use of the app. Given that it only changes the behavior if the shift key is pressed, it seems like it's pretty low risk. Happy to make changes if any are needed.
Thank you! I did not understand first. I will include them in future releases.
On 22. Aug 2020, at 21:46, Paul Marcos [email protected] wrote:
The changes to restore it are included in this PR. I'm running my fork with these changes and it works great, at least for my use of the app. Given that it only changes the behavior if the shift key is pressed, it seems like it's pretty low risk. Happy to make changes if any are needed.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alberti42/iTunes-Volume-Control/pull/30#issuecomment-678684651, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPC4CCRUIX6MPDADN5VJTSCAOCTANCNFSM4QIELMFA.