Volume-Control icon indicating copy to clipboard operation
Volume-Control copied to clipboard

volume not fully mutable

Open benedictstrube opened this issue 1 year ago • 13 comments

First of all, great utility! ❤️

One thing I noticed is, that it does not seem to be possible, to fully mute the volume when Volume Control is running. When pressing the mute button or lowering the volume to the minimum, the volume is marginally higher than 0%. Only muting via the vanilla volume slider from the menu bar works.

Maybe this is something you can look into at some point. Not that important tbh.

benedictstrube avatar Aug 26 '24 09:08 benedictstrube

Thank you for the feedback. Is it possible to send a screenshot? I have never seen this bug before. You can monitor what is happening while you press the volume buttons if you make the app menu visible like in the screenshot.. then you can see whether you effectively reach 0%.

Bildschirmfoto 2024-08-26 um 11 42 08

alberti42 avatar Aug 26 '24 09:08 alberti42

Can confirm, no matter the volume step, the lowest it will ever go for me is ~{volume 0 + volume step}~ very low but still audible.

marckrenn avatar Oct 23 '24 21:10 marckrenn

It is a bit hard for me to debug because I cannot reproduce the bug. See the uploaded video.

https://github.com/user-attachments/assets/a3848bf0-eba7-46b2-b9fb-5774ca314d2e

alberti42 avatar Oct 23 '24 22:10 alberti42

Hey Andrea,

I can confirm that the GUI shows 0% system volume, but if you have media playing, you can still clearly hear it. So the GUI apparently doesn't match the actual volume. This is btw also the case when hitting the hardware mute-key.

I'm on a MBP w/ M1 Pro, if that helps.

Let me know if I can help you debug it somehow. Thanks.

marckrenn avatar Oct 23 '24 22:10 marckrenn

Just took a brief look at the code and I think one of these conditionals needs to be <=

https://github.com/alberti42/Volume-Control/blob/b8ea9f3cfa814b6cd98fd3c29410902d0085a00a/Sources/Controllers/ISSoundAdditions.m#L141

https://github.com/alberti42/Volume-Control/blob/b8ea9f3cfa814b6cd98fd3c29410902d0085a00a/Sources/Controllers/ISSoundAdditions.m#L132

marckrenn avatar Oct 23 '24 23:10 marckrenn

Thanks a lot! I will fix and release a new updated version in the next couple of weeks. Since it is hopefully a not supercritical bug, I hope you will have understanding if I do not do it immediately. Thanks again!!

alberti42 avatar Oct 26 '24 18:10 alberti42

I have to thank you for keeping your your great tool alive! 🙂

marckrenn avatar Oct 26 '24 18:10 marckrenn

I actually found some time from an airport to fix the bug. You can search for new updates and this should allow you to update the app automatically.

Bildschirmfoto 2024-10-27 um 18 00 45

Unfortunately I could not test whether the problem is truly fixed because I am not running on a mac right now. If the problem persists, your feedback is welcome.

alberti42 avatar Oct 27 '24 17:10 alberti42

This fixed it, thank you so much @alberti42 🎉

Safe travels and have a nice Sunday! 😊

marckrenn avatar Oct 27 '24 17:10 marckrenn

Oh no, @alberti42 , it's still there 🙈 It's now barely audible via the MacBook Pro's speaker (had to place my ear on the speaker grill in order to hear it), but it's still audible using headphones.

marckrenn avatar Nov 03 '24 11:11 marckrenn

Oh, I am sorry. I was too fast to push out the release then. The problem is that my hears are not good enough to hear anything when I reached minimum volume. I will have to do more debugging. If you have any idea what the problem is, it is much appreciated.

PS: Just to confirm, if you move the volume bar of Apple Music manually and bring it to zero, the sound is gone?

alberti42 avatar Nov 03 '24 12:11 alberti42

No worries 😊 With the latest update, it’s noticeably improved—I even thought it was fixed! So it’s not a major issue anymore, though obviously, it would still be great if it were fully resolved.

If you have any idea what the problem is, it is much appreciated.

I’ll try looking into it, though I don’t have much experience with MacOS internals or Objective-C, so please keep expectations modest.

PS: Just to confirm, if you move the volume bar of Apple Music manually and bring it to zero, the sound is gone?

Yup, if I do that, it's gone for good.

marckrenn avatar Nov 03 '24 12:11 marckrenn

I have committed a version with debug information about the current and newer volume. You can find the infos in the console of Xcode (if you know how to compile the app) or in the Apple Console app, which you probably can find using spotlight. In the zip file, you find the app already compiled. I am afraid you would have to sign it again.

Volume Control.zip

For some strange reason, Apple forced me to abandon the previous identifier org.Alberti42.VolumeControlApp. So I had to compile the app with

PRODUCT_BUNDLE_IDENTIFIER = com.Alberti42.VolumeControlApp

I say this because you may wonder why the settings are no longer preserved. When I started this project, it was so simple to compile and deploy apps, because there were not all these security barriers. I am not saying that it is bad thing, but it makes everything so more complicated.

Have a look in the video. You should be able to see that you can reach 0% of the volume in the console:

https://github.com/user-attachments/assets/2b8b5283-54c7-4191-bd09-83a25cac379d

alberti42 avatar Nov 03 '24 13:11 alberti42

I think this is a Mac quirk that's being exposed due to a slight difference in behavior between system and Volume Control. Without Volume Control, the system automatically applies mute at volume 0 (via keyboard) whereas Volume Control does not. Without Volume Control running, when I use the keyboard to reduce volume to 0, then untoggle mute, I still get a slight noise bleed, same as when using Volume Control.

mafredri avatar Aug 25 '25 16:08 mafredri

Yes, I figured this out recently and changed the code to fix this behavior. I did not release a new version yet.

alberti42 avatar Aug 26 '25 08:08 alberti42

The system volume is now fully mutable in version 2.0.1. If you think the original issue is not solved yet, feel free to reopen the issue.

alberti42 avatar Oct 01 '25 07:10 alberti42

Awesome, thanks for adding that @alberti42. There's still a minor divergence from OS default where Volume Control doesn't take volume to 0 on that last step, just applies the mute. Functionally there's not much difference, though.

mafredri avatar Oct 02 '25 10:10 mafredri

Yes, @mafredri you found it out. I was planning to fix it in the future. In principle, the default behavior offers one last level called 0, which is not muted yet. I will bring this back in the future. It is not really a bug. It works as intended and made a simplification here because there were many more things to update to comply with modern Tahoe.

alberti42 avatar Oct 02 '25 12:10 alberti42