ngx-papaparse icon indicating copy to clipboard operation
ngx-papaparse copied to clipboard

Type definitions are incorrect

Open OrangeDog opened this issue 4 years ago • 3 comments

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/papaparse/index.d.ts is correct.

This module has, for example, dynamicTyping?: boolean; even though the accompanying doc comment specifies it can also be an object or folder.

OrangeDog avatar Apr 03 '20 13:04 OrangeDog

Hi. Thanks for pointing this out. Feel free to create a PR - and i'll be happy to merge it in.

alberthaff avatar Apr 06 '20 09:04 alberthaff

Would it work if you removed it completely added a dependency on @types/papaparse?

OrangeDog avatar Apr 06 '20 10:04 OrangeDog

Yeah, I think so. This should also lead to less maintenance, since this plugin basically pass the options array to Papa Parse. Most new functions will probably just require that the types and Papa Parse itself are updated.

Please note that the setters and getters for chunkSize, etc. are camelCase in the Papa-service. They are a bit mixed in Papa Parse.

alberthaff avatar Apr 06 '20 11:04 alberthaff

Closing due to inactivity. Feel free to reopen.

alberthaff avatar Jan 20 '23 08:01 alberthaff

Inactivity doesn't make it less of a problem.

OrangeDog avatar Jan 20 '23 08:01 OrangeDog