SimpleAmqpClient icon indicating copy to clipboard operation
SimpleAmqpClient copied to clipboard

Replace boost with C++17?

Open promgamer opened this issue 7 years ago • 5 comments

Hi,

We forked this repository and replaced boost with c++17 features. Do you have interest in a pull request to discuss that changes and have an experimental branch with that?

promgamer avatar May 09 '18 19:05 promgamer

This would be massive improvement imho. Tested your fork and it works fine.

Soldia1138 avatar Aug 05 '18 18:08 Soldia1138

Could we get @alanxz attention on this?

promgamer avatar Aug 06 '18 09:08 promgamer

I will accept PRs that replace boost with newer C++-isms.

I'd prefer if it was c++14 compatible (easier to find compilers that implement the full spec, I'm not sure what all you've used that is c++17 specific).

Keep the PRs small and focused, currently I have limited time for reviews; and smaller PRs are much easier to review.

alanxz avatar Aug 10 '18 16:08 alanxz

@alanxz I'll work on a PR within the next few days.

I've been using GCC 7 (started with version 7.1, now on 7.2, but also tested on 7.3). There's also GCC 8, which I haven't tried yet.

promgamer avatar Aug 13 '18 10:08 promgamer

I've done a similar independent job and created a new fork. C++ 17 is required, since some Boost functionality is still not available in C++14 such as optional.

sa-mustafa avatar Jun 11 '20 20:06 sa-mustafa