Alan West
Alan West
> And then Open Telemetry would use these templates rather the current hard-coded ones I think this is a pretty interesting idea. @cijothomas curious of your thoughts here. I suspect...
A few small CI failures to resolve Static analysis enforces style guidelines. You should be able to produce this locally, but might need to do a release build ``` D:\a\opentelemetry-dotnet\opentelemetry-dotnet\test\OpenTelemetry.Instrumentation.AspNetCore.Tests\BasicTests.cs(665,29):...
> Related issue: https://github.com/open-telemetry/opentelemetry-dotnet/issues/2853 👍 ah, good find! I've updated the description since this PR should resolve the issue.
@al-mac apologies for the delay on this PR! We just discussed it today and would like to get it merged. Would you mind resolving the conflicts?
> would you elaborate the importance and urgency of this change? I do not feel strongly that any change is immediately urgent, but I do think the conversation regarding our...
> The default LogLevel should probably be "None" here I don't recall why I made it "Trace" Ah yea, None makes sense. > Everything else is optional. Yes, understood. The...
Yes, agreed. I think this solves the immediate issues at hand. And big 👍 to the guardrails against using any "ILogger stuff" for non-ILogger things - maybe this is something...
> Keep netstandard2.0 on DS v6. Another big downside to this option: One of the primary use cases of .NET Standard is for folks to put shared code in to...
I'm beginning to flip-flop on my position that we should not target DiagnosticSource 6 for older frameworks. Taking off my .NET hat 🤠 and putting on just my OTel hat...
@tarekgh > do you have more data about that? I can't tell you how much I want to be able to answer this question 😂, but the best I think...