markdown-toc icon indicating copy to clipboard operation
markdown-toc copied to clipboard

Add check for Files>EOL ==="auto" and set it to "\n"

Open PHeonix25 opened this issue 6 years ago • 7 comments

In the spirit of "be the change you want to see", I humbly propose this short solution that fixes issue #65.

FWIW - I haven't tested this conclusively, but it worked for me and saved me from having to change system-wide settings.

PHeonix25 avatar Jan 02 '19 19:01 PHeonix25

Using require('os').EOL should get you the current OS EOL.

ctsstc avatar Jan 05 '19 02:01 ctsstc

@ctsstc - updated as requested. Sorry for the formatting fixes in package.json - it introduces some confusion as to what is an actual change, and what is a layout update. 😞

Also, I don't know the ramifications of changing the "module resolution" to "node", but I had to do that to get it to compile for me, so I've included it in the commit.

PHeonix25 avatar Jan 07 '19 10:01 PHeonix25

I too wasn't sure if we'd have the node namespace available for the extension, so I'm glad you dug into that, but I don't know much about it myself either.

ctsstc avatar Jan 07 '19 20:01 ctsstc

Hey guys,

It would be great if we could have this merged and part of the latest release. I really like this extension.

Cheers!!

surendra-y avatar Feb 18 '19 11:02 surendra-y

Please merge and deploy this!!!!!!!!!!!!!!!!!

ratbeard avatar Jul 19 '19 16:07 ratbeard

Nevermind I just installed https://github.com/yzhang-gh/vscode-markdown instead!!!!!!

ratbeard avatar Jul 19 '19 17:07 ratbeard

I managed to fix all the tslints (which is required to build new version) and merge the pull request. The new version of this extension can be found at this marketplace link Source code

If you found any issue related to code refactoring, please create new issue (and pull request if you can fix it). Many thanks

huntertran avatar Jul 20 '19 13:07 huntertran