markdown-toc icon indicating copy to clipboard operation
markdown-toc copied to clipboard

Emoji should be removed from github.com anchor

Open kennytm opened this issue 8 years ago • 2 comments

  • macOS 10.12
  • VS Code 1.14.2
  • Markdown TOC 1.5.6 (2017-07-25)

Test case:

<!-- TOC updateOnSave:true -->

* [🚲 Hello 🚲](#🚲-hello-🚲)

<!-- /TOC -->

# 🚲 Hello 🚲

...

The generated anchor links to #🚲-hello-🚲, but on GitHub the actual anchor is #-hello-.

kennytm avatar Aug 02 '17 07:08 kennytm

This seems to have been fixed in 0.5.7. Should also be autofixed as the semVer range defined in this package is ^0.5.6. Since the fix was provided ~20 days ago in the dependency I assume you (like me) have a version that's older than 20 days. A simple reinstall on the extension page however doesn't do the trick for me to get the dependencies upgraded. Might be a package-lockor similar. Just head over to the directory and force an update

cd ~/.vscode/extensions/AlanWalk.markdown-toc-*
npm i [email protected]
# restart code completely

You can confirm the dependency version (before or afterwards):

cat ~/.vscode/extensions/AlanWalk.markdown-toc-*/node_modules/anchor-markdown-header/package.json| grep version

anoff avatar Aug 14 '17 15:08 anoff

This can be closed once 1.6.0 is released (in the VS marketplace).

mcornella avatar Sep 22 '20 16:09 mcornella