Jiewen Tan
Jiewen Tan
@kumpera Thoughts on the CPU failures?
Thanks Will for approving it. I will fix all the CI issues before merging.
Changing method signature will definitely affect the LTC migration plan. Wonder if this change can be applied to the upstream LTC as well? @aws-rhsoln
> > @alanwaketan yea, I think this change should also be upstreamed to LTC. > > Can you point me to the LTC code base, I can take a look...
I guess we can see if the same technique can be applied to the upstream first, i.e., having a pull request first. If the upstream PR works, it shouldn't matter...
> @alanwaketan does the upstream one lgty? If upstream pr align the api with this one I can merge this pr to unblock aws team. Reviewing it.
@kumpera I guess I need to take your PR just as what I did in #3983. It's easier for us to produce the hash you would later need in the...
Yea, it's complicated when it comes to a fork.
This seems to be very similar to `distribute_module` in https://github.com/pytorch/pytorch/issues/88838.
> hi all, is there any update for this RFC? Has it been merged into the code base? No, it has not been merged to the code base yet. We...