iasql icon indicating copy to clipboard operation
iasql copied to clipboard

Remove retry from tutorials

Open aguillenv opened this issue 1 year ago • 4 comments

It does not make sense to retry in the tutorials since they use migrations

aguillenv avatar Mar 23 '23 12:03 aguillenv

Approved, but since we also don't recommend migration tools for this, anymore, I am wondering if we should rework this "end-to-end" test, anyway?

dfellis avatar Mar 23 '23 13:03 dfellis

Approved, but since we also don't recommend migration tools for this, anymore, I am wondering if we should rework this "end-to-end" test, anyway?

great point. prisma doesn't use migrations, but Django does. created this issue to fix that https://github.com/iasql/iasql/issues/2354

depombo avatar Mar 23 '23 13:03 depombo

Approved, but since we also don't recommend migration tools for this, anymore, I am wondering if we should rework this "end-to-end" test, anyway?

great point. prisma doesn't use migrations, but Django does. created this issue to fix that #2354

That wasn't what I had in mind, exactly. I think both should be reworked to follow the guide you wrote for change management. The guide is pure SQL, and we should try to replicate these examples that way, and then we should see if/how to do change management that way via ORM, but that would require changes to the Prisma tutorial, too.

dfellis avatar Mar 23 '23 13:03 dfellis

That wasn't what I had in mind, exactly. I think both should be reworked to follow the guide you wrote for change management. The guide is pure SQL, and we should try to replicate these examples that way, and then we should see if/how to do change management that way via ORM, but that would require changes to the Prisma tutorial, too.

I think we should do that too, but that seems like another task / somewhat orthogonal to removing migrations from Django. A tutorial is a quickstart on how to get started with something quickly. I think it might make sense to modify those existing blogs/tutorials, but it could also end up being another example altogether where the markdown file itself is committed and so on.

depombo avatar Mar 23 '23 13:03 depombo