iasql icon indicating copy to clipboard operation
iasql copied to clipboard

Drop old version from dockerhub on release

Open depombo opened this issue 3 years ago • 5 comments

depombo avatar Feb 11 '23 05:02 depombo

Do we actually want to do this? Keeping the earlier versions around shouldn't be a huge issue and if we get people who feel like they are "stuck" on an earlier version because of backwards-incompatible changes, this gives them an escape valve and we can figure out how we're going to handle that.

dfellis avatar Mar 03 '23 23:03 dfellis

if we get people who feel like they are "stuck" on an earlier version because of backwards-incompatible changes

I don't think this will happen for some time, but I'm sure it will eventually.

This is minor, but the reasoning behind this task is that we drop old doc versions so if they are on an old version they have no documentation for it. I think the dockerhub and docs versions should match for now until we revisit a different version support range / lts / etc which seems out of scope for now.

depombo avatar Mar 04 '23 16:03 depombo

I was imagining the opposite. There's no real reason why we can't bake the docs into the dashboard when being used locally, so anyone using locally would have the correct docs and anyone using the SaaS would have the correct docs, and they don't have to be kept in lockstep with a convoluted deploy or LTS process.

dfellis avatar Mar 04 '23 16:03 dfellis

hmm that is a larger architectural change, but possible and could make sense. the friction point there is exposing static doc pages and keeping them optimized for SEO as docusaurus does versus the dynamic nature of the dashboard, but perhaps we can duplicate it?

depombo avatar Mar 07 '23 19:03 depombo

Depending on how we intend to duplicate it, it could be something more baked into dashboard itself, like a side panel that slides out and shows you the docs, covering part of the UI but leaving the editor visible, so you can read the reference while working on the SQL at the same time.

dfellis avatar Mar 07 '23 19:03 dfellis