iasql icon indicating copy to clipboard operation
iasql copied to clipboard

pure SQL ecs simplified module

Open depombo opened this issue 2 years ago • 1 comments

There are still a few things missing, but since the module is not exposed I am hoping to land this before the release so I don't have to port over my work.

depombo avatar Aug 22 '22 19:08 depombo

looking good! It does look simpler to maintain. My question here is, if someone creates a service using ecs_simplified, then uninstall the module and installs it again, are they going to see the resource they just created?

In this PR, the resource would not be recognized again on uninstall/install. However, next PR on install/sync will uncomment that test to add a function called recreate_ecs_simplified which is currently commented out that checks that any ECS services that match the configuration that we use and register it into the ecs_simplified table even if they weren't created with ecs_simplified in the past effectively making it stateless

depombo avatar Aug 22 '22 21:08 depombo

looking good! It does look simpler to maintain. My question here is, if someone creates a service using ecs_simplified, then uninstall the module and installs it again, are they going to see the resource they just created?

Updated the PR description explaining how I get around this.

depombo avatar Aug 30 '22 14:08 depombo