david-www icon indicating copy to clipboard operation
david-www copied to clipboard

Badge colour always green when all dependencies pinned

Open alanshaw opened this issue 11 years ago • 2 comments

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned all dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will always be green.

I propose that when all dependencies are pinned, absolute versions should affect the David badge colour.

alanshaw avatar Jul 16 '13 18:07 alanshaw

+1

lo1tuma avatar Oct 14 '13 21:10 lo1tuma

Or at least give us the option to override the default behaviour - eg another parameter in the badge URL :-)

Without this, the badges are somewhat useless to us at the moment sadly.

edmorley avatar Oct 05 '15 16:10 edmorley