david-www icon indicating copy to clipboard operation
david-www copied to clipboard

Wrong badge status in case of pinned deps

Open arikon opened this issue 10 years ago • 5 comments

Here is the case:

2014-11-17 15-48-15 dependency status for lego - enb-islands-tools 0 6 3

But David shows yellow up-to-date button:

2014-11-17 15-48-49 dependency status for lego - enb-islands-tools 0 6 3

I expect it to be red out-of-date.

arikon avatar Nov 17 '14 12:11 arikon

Yep, that's weird - it should be red!

alanshaw avatar Nov 19 '14 13:11 alanshaw

@arikon can you provide link to test it?

aivus avatar Nov 30 '14 13:11 aivus

@alanshaw, In the current implementation david calculate percentage of the "out of date" dependencies.

          if (totals.unpinned.outOfDate / depList.length > 0.25) {
            status = "outofdate"
          } else {
            status = "notsouptodate"
          }

We can replace condition on totals.unpinned.outOfDate > 0.

aivus avatar Nov 30 '14 13:11 aivus

@aivus I can't, because it is on the in-house instance of David.

arikon avatar Nov 30 '14 15:11 arikon

This is still a bug, and renders the badge completely useless as one of the projects I have it in has all the package versions pinned.

xPaw avatar Oct 22 '16 06:10 xPaw