monotorrent icon indicating copy to clipboard operation
monotorrent copied to clipboard

looks like monotorrent got memory leak in tracker

Open OneFingerCodingWarrior opened this issue 3 years ago • 2 comments

image image

OneFingerCodingWarrior avatar Jun 29 '21 11:06 OneFingerCodingWarrior

it's related to SemaphoreSlimExtensions, after i comment out using (await AnnounceLimiter.EnterAsync ()) everything back to normal

OneFingerCodingWarrior avatar Jun 29 '21 13:06 OneFingerCodingWarrior

Can you share a minimal repro please?

mfkl avatar Aug 11 '21 10:08 mfkl

This should be fixed now. This issue would manifest when there were over 10 tracker tiers in a torrent, and the trackers within that tier frequently timed out or were unresponsive.

The fastpath which discarded excessive announce attempts occurred after rate-limiting was applied, but announce attempts should have been discarded before rate-limiting was applied. That meant a significant queue of attempts could build up when there were dozens/hundreds of tracker tiers, though the majority of those queued attempts would be a no-op in the end.

alanmcgovern avatar Nov 12 '22 15:11 alanmcgovern