Alan King

Results 170 comments of Alan King

I agree. clang-tidy is a work in progress from a configuration perspective so I think the remaining issues are invalid. Let's # it.

I see that this has already been done. Merging

I found that the log file is being generated again in pre-4.3.0: ```bash $ ls -l /var/lib/irods/log total 176 -rw-r--r-- 1 irods irods 30651 May 26 18:24 control_log.txt drwxr-x--- 2...

Right. A possible resolution for this issue is that this should not be allowed. Haven't really thought through/discussed it all the way yet

The failure appears to be occurring when the collection mtime is being updated after the rename operation. The reason the failure only occurs when connected to the catalog service consumer...

Can you confirm that the `irods-externals-avro1.11.0-1.x86_64` package is installed on the machine?

Ooh, you're right, @cgrzemba I performed the steps above on 2 4.2.10 zones and got a different result. The `iqstat` output looks identical to 4.2.11: ``` Pending rule-executions id: 10022...

Ah, very good find. The problem seems to be this: As of https://github.com/irods/irods/commit/579d0c2958d69e5c510e903907310d374799e866, delayed rule deletion is now *correctly* checking the permission level of the client user rather than the...

One more clang-format thing and I think this will be good to go

You can configure `clang-format` with `git` by following the instructions in the GitHub Actions workflow: https://github.com/irods/irods/blob/fc0653187ec7a308a466529aa76917c723c06995/.github/workflows/linter-irods-clang-format.yml#L29-L35 *Or* you can apply the diff directly using `git apply` since it's pretty small:...