alankelly

Results 49 comments of alankelly

GELU support in XNNPACK

GELU is not on our roadmap, however, please feel free to add the required operator & subgraph support & scalar microkernels. XNNPACK has strict precision requirements, the maximum error of...

GELU support in XNNPACK

XNNPack now supports GELU: https://github.com/google/XNNPACK/commit/8b9fe2602ffc510a42f72d4d8920fff5c9c4447f

Add f32 Maxpool RVV implementation microkernels, tests and config changes.

Can you please rebase and I will land first thing on Monday?

Add f32 Maxpool RVV implementation microkernels, tests and config changes.

Thanks importing now

ARMv7 (with NEON) can not support on Linux but only support ARMv7 (with NEON) on Android

Is this issues still relevant? Can we close?

Fix cmake for pthread and cpuinfo with USE_SYSTEM_LIBS

Are you sure that this isn't an issue with the setting of PTHREADPOOL_SOURCE_DIR and CPUINFO_SOURCE_DIR?

`xnn_weights_cache_provider` look_up doesn't work?

Hi, is this still an issue? Do you want to discuss during the next meeting?

XNN_FLAG_KEEP_DIM not backwards compatible

Sorry for the mess with this. This flag should have been XNN_FLAG_REDUCE_DIMS to maintain behaviour. However, before we could roll it back it got picked up by other projects. We...

Xnnpack still builds with `+dotprod` and `+fp16` with `-DXNNPACK_ENABLE_ARM_DOTPROD=OFF -DXNNPACK_ENABLE_ARM_FP16_SCALAR=OFF -DXNNPACK_ENABLE_ARM_FP16_VECTOR=OFF`

What version of XNNPack are you building? The failing file was removed on Sep 26, 2022

Xnnpack still builds with `+dotprod` and `+fp16` with `-DXNNPACK_ENABLE_ARM_DOTPROD=OFF -DXNNPACK_ENABLE_ARM_FP16_SCALAR=OFF -DXNNPACK_ENABLE_ARM_FP16_VECTOR=OFF`

Can you update to the latest release? We can't fix old releases.