sweb icon indicating copy to clipboard operation
sweb copied to clipboard

Youtube Video issue

Open BioBut opened this issue 4 years ago • 4 comments

please add youtube video play to Official Youtube app youtube video background playing api issue and night Mode Feature: issue

BioBut avatar Jan 18 '21 03:01 BioBut

There is no native night mode in WebView, so I'm faking it with injected CSS in the injectCss function: https://github.com/alandau/sweb/blob/87d013c689e9a4fcdad2603abac021cd5bab4d94/app/src/main/java/landau/sweb/MainActivity.java#L1424

If I understand what you're saying correctly, some videos disappear due to that CSS. If you want this fixed, please send a PR that modifies the injected CSS to do the right thing for videos.

alandau avatar Jan 24 '21 00:01 alandau

There is no native night mode in WebView, so I'm faking it with injected CSS in the injectCss function:

https://github.com/alandau/sweb/blob/87d013c689e9a4fcdad2603abac021cd5bab4d94/app/src/main/java/landau/sweb/MainActivity.java#L1424

If I understand what you're saying correctly, some videos disappear due to that CSS. If you want this fixed, please send a PR that modifies the injected CSS to do the right thing for videos.

reference:

specific website open official app (Google play app, youtube app) https://github.com/mjbdl/Premium-SmartWebView

Night Mode https://github.com/dmitrylaas/evobrowser

Home screen Shortcut https://github.com/sazid/Browse

BioBut avatar Jan 26 '21 09:01 BioBut

I think the current night mode is not so good just only because the contrast very little. Therefore, it's very difficult to read. Maybe the night mode is just changing the background from white to darker colour like 0xdddddddd or 0xeeeeeeee, the characters no need to change

PowerExplorer avatar Jun 28 '21 04:06 PowerExplorer

No, the whole point of night mode is to have a dark background, so that the eyes are not strained when reading in a dark room at night. Low contrast is also by design, otherwise a full screen of bright letters defeats the purpose of dark mode.

Unfortunately, some content on some sites is removed/made unreadable due the the CSS used for night mode. As I said above, I'll accept a fix.

please add youtube video play to Official Youtube app

If I understand correctly what you mean here, the feature is already implemented in v1.5. Press menu, then "Open URL in app", and if an app supporting the current URL is installed (e.g. YouTube, Amazon, etc.), the URL will open in the app.

alandau avatar Jun 30 '21 00:06 alandau