bulletproof-react icon indicating copy to clipboard operation
bulletproof-react copied to clipboard

Dependency cycle

Open w6fux5 opened this issue 2 years ago • 2 comments

lib/auth.tsx import { loginWithEmailAndPassword, ... } from '@/features/auth';

features/auth/components/LoginForm.tsx import { useAuth } from '@/lib/auth';

Wouldn't this Dependency cycle?

w6fux5 avatar Aug 28 '22 04:08 w6fux5

Hi there!

You are right, it is. As the matter of fact, this is not the only case in the app, there are more. If you add the "import/no-cycle" rule to the eslint configuration, you can see them all.

This is something that has been overlooked when the app was initially built, but I am already aware of the issue and plan to update the application when I get the time to do so.

Thanks for reporting it.

alan2207 avatar Aug 28 '22 18:08 alan2207

@alan2207 I believe lib layer should know nothing about features layer

kaguya3222 avatar Jan 16 '23 12:01 kaguya3222