bulletproof-react icon indicating copy to clipboard operation
bulletproof-react copied to clipboard

Update and replace outdated packages

Open PrettyCoffee opened this issue 1 year ago • 2 comments

Hey, this PR is tackling the upgrade discussed in #151.

Unfortunately, I wasn't able to split it into several PRs, since there are too many co-dependencies (especially doing anything related to a newer node version)

I think we got 3 options for how to proceed with this:

  1. You review this monstrosity of a PR
  2. If you don't mind a temporary broken state, we could also split this PR into multiple parts that take care of fixing and modernizing one part at a time (e.g. eslint -> msw -> vite -> vitest etc)
  3. We create an migration branch, remove some things to have a minimal state and then start adding part by part back

I tested all available scripts and everything seems to be working. (On windows) That being said, I am not familiar with all of the installed packages and I also wasn't able to run the project in its original state.

PrettyCoffee avatar Apr 28 '24 17:04 PrettyCoffee

Deploy Preview for bulletproof-react-app failed.

Name Link
Latest commit 0fa3d8f746431e636e76eb4d7c422d359d19a1d1
Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/662e88c62ee83a0008aa2b77

netlify[bot] avatar Apr 28 '24 17:04 netlify[bot]

hey @PrettyCoffee , thanks a lot for putting this together. Funny thing, I also started migrating stuff yesterday and here is my draft PR: https://github.com/alan2207/bulletproof-react/pull/152 . Besides a couple of flaky tests, everything else is in place and working. I will review your PR as well and see which one fits more to be merged.

alan2207 avatar Apr 28 '24 17:04 alan2207

Hey @PrettyCoffee , thanks again for making the effort to submit this huge PR. I went through your changes and added some good things from this PR into https://github.com/alan2207/bulletproof-react/pull/152 . Everything should be updated now with more modern stack, and other improvements.

alan2207 avatar May 14 '24 07:05 alan2207