scivision icon indicating copy to clipboard operation
scivision copied to clipboard

Get scivision to work with python >=3.10

Open edwardchalstrey1 opened this issue 2 years ago • 3 comments

I noticed when adding a test for load_pretrained_model in scivision/io/reader.py that the test was failing on GH actions because we had it set up to use 3.X which was using 3.10 and model loading doesn't seem to work for that version. Have now changed GH actions to 3.9, but we may want scivision to work with 3.10.

test_load_pretrained_model tries to install the test model: https://github.com/quantumjot/scivision-test-plugin which results in the following error when in python 3.10:

ERROR: Could not find a version that satisfies the requirement tensorflow (from scivision-test-plugin) (from versions: none)

so may need to investigate whatever the issue with tensorflow is.

Possible extra TODO:

  • [ ] Make GH actions create the conda env specified in environment.yml and use that

edwardchalstrey1 avatar Nov 19 '21 14:11 edwardchalstrey1

right now setup.py implies that it will work with all versions >= 3.7

edwardchalstrey1 avatar Dec 01 '21 15:12 edwardchalstrey1

this might not be super important as it only applies when loading a model that uses tensorflow

edwardchalstrey1 avatar Dec 07 '21 16:12 edwardchalstrey1

this might not be super important as it only applies when loading a model that uses tensorflow

I agree - the official Docker images of TF are up to 3.8 now!

quantumjot avatar Dec 08 '21 16:12 quantumjot

Closing as on closer inspection this is not a scivision issue, but a problem concerning clashing Python and Tensorflow versions

edwardchalstrey1 avatar Nov 09 '22 10:11 edwardchalstrey1