data-safe-haven icon indicating copy to clipboard operation
data-safe-haven copied to clipboard

Add test for help function

Open jemrobinson opened this issue 9 months ago • 1 comments

:white_check_mark: Checklist

  • [x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • [x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • [x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • [x] You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

:arrow_heading_up: Summary

:closed_umbrella: Related issues

Addresses point from #1853 review

:microscope: Tests

Tested locally

jemrobinson avatar May 03 '24 08:05 jemrobinson

In general, I don't like how cli.py is structured. It isn't very idiomatic typer.

I think it would be much clearer and easier to use if it followed the normal model of a typer.Typer object and typer.Typer.command decorators.

Are you happy to make that change on this PR?

jemrobinson avatar May 03 '24 13:05 jemrobinson