react-native-fast-shadow icon indicating copy to clipboard operation
react-native-fast-shadow copied to clipboard

add RN New Arch Fabric support

Open byrizki opened this issue 2 years ago • 3 comments

This pull request implement RN New Architecture Fabric for Android

byrizki avatar Mar 15 '23 04:03 byrizki

Thanks @muhamad-rizki for your work on this, it's really appreciated 🙏

Unfortunately, I was not able to make it work on my end in the example app from your branch. When I run the Android app with Fabric enabled with your changes, here is what I get:

Are there specific instructions to follow to build the app with Fabric enabled, other than setting newArchEnabled=true in gradle.properties?

I test it with my apps directly instead from example folder with RN version 0.71, I tried to build the example folder with newArchEnabled=true but I cannot get it compiled yet with exception

error: package com.swmansion.reanimated does not exist
import com.swmansion.reanimated.ReanimatedPackage;

it looks like RN Reanimated only support fabric with RN version 0.70+, I can make it compiled when removing reanimated example.

And it looks like RN New Arch Auto linking is supported from RN v0.70+, that's why example apps not worked (https://reactnative.dev/blog/2022/09/05/version-070#android-auto-linking-for-new-architecture-libraries), it need some adjustment on example app (https://github.com/alan-eu/react-native-fast-shadow/pull/9/commits/193ab4c4ea3c2a7669937362814861c44e326db6) image

byrizki avatar Mar 26 '23 05:03 byrizki

is this pull request ready for merge?

kunger97 avatar Dec 29 '23 01:12 kunger97

Hi @simontreny I just updated the example app and solving conflicts, can we merge this so this library can support RN new architecture? image

byrizki avatar Oct 09 '24 22:10 byrizki