Andrew Lamb

Results 1724 comments of Andrew Lamb

> @alamb Do you think this is a reasonable change ? @Ted-Jiang I do -- perhaps by default the explain plans can summarize the information (e.g. print out the first...

Nice -- thanks @turbo1912 !

Hi @waitingkuo -- I think given the desire to make datafusion "A Declarative SQL query interface compatible with PostgreSQL" as described on https://arrow.apache.org/datafusion/specification/roadmap.html#datafusion compatible changing the current `to_timestamp` to be...

> Summary & My proposal Makes sense to me. 👍 cc @ovr @andygrove @seddonm1 @stuartcarnie (not sure if anyone else is interested in this discussion too) > start another thread...

> @alamb should we consider to_timestamp() to output timestamp with time zone? I think that can be a long term goal -- I suspect making that change will be hard...

> probably we need to deal with datatype date / time / timestamp / time zone first and then move to this timestamp related functions I agree that sounds wise

Possibly related / redundant with @stuartcarnie 's https://github.com/apache/arrow-datafusion/pull/3010

Here is a self contained reproducer for anyone following along: ```sql ❯ create table foo as select column1 as d from (values (1), (2)); +---+ | d | +---+ |...

And we can see that as @liukun4515 says the casting is added in the physical plan (rather than the logical plan): ```sql ❯ explain verbose select * from bar where...

I agree the ideal outcome would be that the logical plan has the casts. I think the reason the type coercion / casting happens in the physical planner was some...