Andrew Lamb comments

Results 2253 comments of


                                            Andrew Lamb

Expose a method for mutating Parser::index

> We propose adding and exposing a new method in sqlparser's Parser, such as set_index or index_mut, to allow users to mutate the index. I think this makes sense to...

Cannot parse `select 1 in ()`

Possibly some good guidelines: https://github.com/apache/datafusion-sqlparser-rs?tab=readme-ov-file#syntax-vs-semantics

The syntax of mysql RENAME TABLE tb1 TO tb2 is not supported.

Thanks for the report @charmfocus . We would welcome a PR with tests to improve support

Eliminating whitespace from the parser logic

> The overall goal sounds reasonable to me, but I'm not sure that I can fully judge the impact of the changes > > [@alamb](https://github.com/alamb) [@yoavcloud](https://github.com/yoavcloud) do you have any...

Add lifetime to token

I'll try and review this one over the next few days

Expand parse without semicolons

I don't think I am likely to have time to review this PR any time soon unfortunately

Improve performance by reducing string copies

FYI for your amusement @iffyio and @yoavcloud

Improve performance by reducing string copies

Thank you @eyalsatori -- this sounds like a great incremental way to move this project along So with this strategy, as I understand it, any existing users of `Token` (aka...

Improve performance by reducing string copies

> I'd like to suggest creating a feature branch where we can open and merge related PRs for this issue. Once we've proven the concept adds real value to the...

Improve performance by reducing string copies

This is awesome -- thank you @eyalleshem -- I will prioritize getting this reviewed shortly