Andrew Lamb

Results 1677 comments of Andrew Lamb

Thanks @OscarTHZhang I think part of this ticket would be to define a reasonable test workload Here are some examples of benches that might server as inspiration: * Single Operator:...

Hi @OscarTHZhang Thanks for commenting on this ticket. > I think we can divide the micro-bench into 2 types (as described above) I think the core goal for the ticket...

git blame https://github.com/apache/arrow-datafusion/blame/master/datafusion/sql/src/planner.rs#L185-L198 seems to show it came in via the initial support for views in https://github.com/apache/arrow-datafusion/pull/2279 by @matthewmturner

Hmm, something is not correct. Will investigate

I don't have time / plans to work on this any more

🤔 now that I see how this looks I am not convinced it saves much duplication

I don't think this is worth pursuing at the current time

Thanks @ming535 ! That list looks good to me > Is there anything I am missing? I think I need to do some research on how to implement List, Struct....

I think Distinct basically serializes partial results as `List`s when combining partial aggregates

> Does this mean that the design was meant to support some thing like: COUNT(DISTINCT (c1, c2)) which counts the distinct combination of c1 and c2? I am not totally...