Andrew Lamb

Results 1749 comments of Andrew Lamb

Thanks @goldmedal -- I hope to review this PR this wekeend, likely tomorrow

I am sorry for the delay -- I plan to review this tomorrow

I think options 1 or 3 would work well In terms of an example being complicated, I find that is one of the benefits of working on adding such examples...

I plan to give this a carefully look again tomorrow

I apologize for not finding time yet to re-review this PR. It contains a substantial seeming API change and I need to find enough contiguous review time to review it...

BTW I think https://github.com/apache/datafusion/pull/11516 is very related to this PR -- maybe once we get that one in then the API changes needed for this feature will become more natural...

We plan to merge https://github.com/apache/datafusion/pull/11516 tomorrow

Converting to draft so it is clear this isn't waiting on additional review (yet)

It would be pretty interesting to try and refresh this code / idea now that @findepi has managed to extract the Catalog traits out of the core https://github.com/apache/datafusion/pull/11516

> fter making some changes, I encountered failures with Rust linking with cc, which failed 😢. I' Sometimes I have found that wiping out the `target` directory solves this problem...