Andrew Lamb

Results 1764 comments of Andrew Lamb

> I find a way to avoid clone, returns tuple Result original_expr and new_expr mutually exclusive That is a good idea. I think we might be able to name the...

> Extend it for more kinds of rewrite like FieldAccess plan_field_access Yes, good idea > Given the current design, if we want to support plan_field_access we need to add the...

Here is a proposal for how to proceed: 1. Merge https://github.com/apache/datafusion/pull/11155 (so we don't have a third pattern to deal with) 2. Make a PR with a production ready version...

> This sounds like a good plan. > > We (I) should also adapt/restart [datafusion-contrib/datafusion-functions-json#22](https://github.com/datafusion-contrib/datafusion-functions-json/pull/22) to work with this API to prove it does what we need before merging. I...

While working with @lewiszlw in https://github.com/apache/datafusion/pull/11173#issuecomment-2198280594 I think I came up with a better idea -- that is to update the user guide so they code examples are run /...

I played around with what we have and it turns out I think we can test examples in the user guide. I made a PR with docs of how to...

I plan do to this as a background task, but realistically can't devote enough focus time to it now

Thank you @logan-keede 🙏 After https://github.com/apache/datafusion/pull/14240 I don't think there is any example left for consolidation that I can see

> [@alamb](https://github.com/alamb) I think there is one more thing we can do, though perhaps it is only my preference. > > We can consolidate them into folders, a big `sql.rs`...

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look