Andrew Lamb

In terms of implementation, what I suggest is: 1. Do a POC implementaiton: wire up just enough `StringView, don't worry about GC, basic unit tests 2. Verify it makes the...

BTW in case anyone is interested, I recorded a short video on how to make these flamegraphs: https://youtu.be/2z11xtYw_xs I will add a link to that in the docs later

> The challenge of `String` seems that? > > * If we just simply use a `Vec` like `primitives` to keep the min/max values, it is too expensive to convert...

@Rachelint your implicit idea of using `Vec` to store the state I think is actually quite interesting and maybe we should try that one first: It would at least avoid...

> I am not familiar enough with StringViewArray, is it ok to do that? And will it lead to a extremely bad performance? I think using a single `Buffer` for...

> > > I am not familiar enough with StringViewArray, is it ok to do that? And will it lead to a extremely bad performance? > > > > >...

BTW I was thinking more about this issue -- while a native Min/Max for strings / stringview will help, I have an idea that might make it simply it an...

> I think what @alamb means is that just simply using Vec to store the states will be at least not worse than StringArray + GroupsAccumulatorAdapter, and it is easy...

An update here is that @XiangpengHao has a PR with various changes in https://github.com/apache/datafusion/pull/11862 We still need to check that PR and figure out what else is in that PR...

My ideal resolution here is that we end up in the state where the only change we need to enable string view by default is switch the config setting. I...