Finished up work started in PR (#263) auto incrementing the port if it is already in use
Finished up work started by @al5ina5 in PR (#263) auto incrementing the port if it is already in use
This adds the following ontop of the work already started by @al5ina5:
- Added new tests
- Added the port to reload's return object so the calling program knows what port reload ending up using if the port auto increments
- Added autoIncrementPort optional param to realod to turn off auto port incrementing. Default
true - Tweaked the code to work correctly, like handling the promise return correctly
- Small tweaks to how the generated client side code replace works. Removed a branch that wasn't hitting in coverage and made it more readable
- Updated README with API changes
Closes #256
Branched off work from PR #263
Codecov Report
Merging #278 (ff58c31) into master (b3c4e8c) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 131 144 +13
=========================================
+ Hits 131 144 +13
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/reload.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c0271a6...ff58c31. Read the comment docs.
Hey, this is awesome to see. 👍
Thanks for tagging me. Hope I didn’t give you too much trouble! 🤞🏼
@al5ina5 no problem at all you got the ball rolling. You should be a first time reload contributor soon when this gets merged!
Per #256 we should still reject if the auto increment option is turned off and there is a port conflict