Massimiliano Culpo
Massimiliano Culpo
@scheibelp Following our discussion on Monday, here's some stats for reference. **Spack base commit:** b6ea2a46d1821539c88e810ecdac538a72feff77 ```python def setup_build_environment(self, env): ... ``` This method is overridden by 362 packages out of...
@spackbot run pipeline
@scottwittenburg @zackgalbreath I restarted Gitlab pipelines here, and noticed that some build issues that should have been solved are still there. Then, investigating more [this pipeline](https://gitlab.spack.io/spack/spack/-/pipelines/164913) I saw that the...
@spackbot run pipeline
For reference, a pipeline where we are rebuilding almost everything from scratch (touched zlib and other fundamental packages): https://gitlab.spack.io/spack/spack/-/pipelines/165830
@spackbot run pipeline
> This is looking much better than the last time I reviewed! Glad to hear that. Also glad that little changed in the high-level design! > If I'm understanding correctly,...
> At this point, do you have a general preference between this PR and https://github.com/spack/spack/pull/30411? Which feels like "the right way to do things" from a core developer perspective and...
> Package X defines a builder but X also defines cmake_args This is definitely something we want to catch with an audit, and it should not be possible at all.
> a package defines a builder which defines new phases Didn't we set on allowing this on a specific class of builders? I'd be fine allowing custom phases on e.g....