eslint-plugin more rules candidates

Feb 10 '19 10:02 aladdin-add

Also max-len, which will be hard.

Feb 10 '19 10:02 g-plane

Do we need to consider indent if we implement "max-len"?

Feb 11 '19 05:02 g-plane

every rule should be standalone. that's means it could not depend on rule indent.

related issue: https://github.com/eslint/eslint/issues/11325

Feb 11 '19 05:02 aladdin-add

If we implement "max-len", I think I don't need to use Prettier in other projects any more.

Feb 11 '19 07:02 g-plane

Should we add autofix for "no-unreachable"?

Feb 12 '19 00:02 g-plane

Feb 12 '19 02:02 g-plane

no-unreachabl sounds good to me!

not very sure about no-async-promise-executor. :(

Feb 12 '19 04:02 aladdin-add

我们不妨去 ESLint 的列表找找哪些规则还没有 autofix 的，然后看看哪些值得去实现，接着在这个 repo 针对每个规则单独开 issue 进行讨论（实现思路），如果讨论没问题就打个 accepted 的 label，如果思路不可行就直接关闭掉 issue。你怎么看？

Feb 12 '19 06:02 g-plane

可以，优先考虑在 eslint:recommended 中的规则

Feb 12 '19 06:02 aladdin-add

我不确定还要不要实现 max-len 的 autofix，因为修复出来的结果往往是 opinionated 的，而我们也许不能保证这是不是用户想要的结果。

Feb 24 '19 16:02 g-plane

refs: https://github.com/eslint/eslint/issues/11542

Mar 25 '19 04:03 aladdin-add

How about no-lone-blocks?`https://eslint.org/docs/rules/no-lone-blocks

Feb 20 '20 10:02 mekwall

@mekwall sounds good to me!

Feb 20 '20 11:02 aladdin-add

Someone implemented sort-keys but it was a year ago https://www.npmjs.com/package/eslint-plugin-sort-keys-fix

Apr 21 '21 18:04 trajano

any updates on max-len?

Feb 06 '22 16:02 danielanthonyl

Please add max-len. Its the only thing holding me (and it seems others) back from throwing Prettier out …

Feb 09 '24 20:02 cseelus

eslint-plugin eslint-plugin copied to clipboard