唯然

Results 228 comments of 唯然

just like in the PR https://github.com/eslint/eslint/pull/14010, the bot commented 3 times: * https://github.com/eslint/eslint/pull/14010#issuecomment-761737961 * https://github.com/eslint/eslint/pull/14010#issuecomment-761738076 * https://github.com/eslint/eslint/pull/14010#issuecomment-761738132 it makes a little harder to read, I think it's better not to...

严格来说,全局变量也有这种情况(比较少见): ```js var obj = Object.defineProperty(window, 'prop', { get() { /* 产生副作用 */ } }); prop; // window.prop ```

一般get函数是没有副作用的,所以移除掉的话也算合理。

what if `cb && cb();`?

hi, thanks for the report! I think it was not fixed, as we cannot tell whether it has side effects: ```js var foo = bar(); // cannot be safely removed....

every rule should be standalone. that's means it could not depend on rule `indent`. related issue: https://github.com/eslint/eslint/issues/11325

`no-unreachabl` sounds good to me! not very sure about no-async-promise-executor. :(

可以,优先考虑在 eslint:recommended 中的规则

+ sort-keys refs: https://github.com/eslint/eslint/issues/11542