唯然

Results 217 comments of 唯然
trafficstars

1. Is it only used to introduce experimental features, or is it potentially used for others? 2. unlike others, experimental features, imho, is allowed to introduce breaking changes in non-major...

it cannot be reproduced in the playground(as lacking the package `globals`). I was able to [repro](https://eslint-online-playground.netlify.app/#eNqNU1Fv2jAQ/iuWXwKIJIVHqk2VWqZp6sTDpr7UPBjnSM0cO7UdAkL57zuHwJKqU6tIYPu+u/v8+bsTdVakcOBFqSDZObqgsiiN9eREau7Fy5OEOuy/g8xfPGnI1pqCRHepE1aW3qWVl0r6Y/oOOmKa6cyIqgDtE55lyz0uHqXzoMGOoofVz3ujceMfDc8gi6ZkNCZfvpIT0+S99qMx082YTik4JbGkMHor8wHtXJkNV+5Mk9Fuy+gt0x2iVFUu9Y8r5O5cLN2dUeGDQ4vMYMsr5clzoHNJ65q6xIIwBd4MiU8DoCVNyFYqcAvyHCVpkHYySSdIMFq3GEIU13nFc1iVXhrtyOKSRy7UeyeEJEnSHScba2oHtqvzJghufjOfXULNFQSi4E9gHfZakNn8eu5MZQX8PpawIFFhskpB1AUvyRbP+mQibWK8uzMIDferudXXa2FYohLatyGw1lh8zfkUbRT9qiW+5D13IW9Gml7Oa2U8uEFO5KTOA5uQyvdGZksneBlyva1gkO5KLiBDVuEdhq0jrmp+/Kd7QEMhhxgNe7B9iNnsQPhYVFYd41AduXxUNnTncYbv2gnz//JgVKy4+5ApKl2g8STOZAxF6Y8xOvSNTqhOwQ9BUSyBq+XqG25uBvrAa/g+0W3PbQ+17owQ/vBnfYsTh1r8QduilY3GaWtdwahHAzG6wNXZQ4y2ZRnNYP8AZRgOLSTgZF2NxLrhPacpju+P645Nb2BDdMJox6GhzV+kMHsw). ```diff - files: ['./src/**/*.js'], + files: ['src/**/*.js'], ``` It's working as expected after the...

> Patterns starting with ./ are effectively ignored. Perhaps config-array should throw an error if there's a files or ignores pattern starting with ./, to avoid confusion. or just stripping...

> invalid: [{code: "", errors: [{message: "xxx", suggestions: null}]}] ✅ ❌ Test error object property 'suggestions' should be an array or a number. > > I think the current behavior...

> valid: [{code: "foo"}], invalid: [{code: "foo", errors: 1}] ✅ ❌ detected duplicate test case > > I think there's not much value in detecting duplicates between valid and invalid...

@Pixel998 thanks, but i had a wip (~90%) pr. 😄

just want to point out: it should be a breaking change to change a rule's default option.

per the versioning-policy, the fix could be a breaking change (rule schema changes): https://github.com/eslint/eslint?tab=readme-ov-file#semantic-versioning-policy We can table it for v10. thoughts? @eslint/eslint-team

surely `[]` is a valid config. it can throw an error when: * exporting a non-array. * no exporting. something like: ```js const config = (await import(fileURL)).default; if(!Array.isArray(config)){ throw new...