alacritty icon indicating copy to clipboard operation
alacritty copied to clipboard

[Feature] Support for true borderless option in macOS

Open badfilms opened this issue 6 years ago • 4 comments

Using macOS 10.14.1, the borderless options still display a border.

The screenshots are using decorations: none

screen shot 2018-11-15 at 12 45 24 am screen shot 2018-11-15 at 12 45 02 am

badfilms avatar Nov 15 '18 05:11 badfilms

This is likely because the terminal content doesn't fit the window size correctly. It's not possible to display half cells, so a padding has to be added. This is the intended behavior.

There's #1780 and #388 are related to this problem and the latter is probably what this is a duplicate of.

Please let me know if I've understood this issue incorrectly and I'll re-open. But I think it's already covered in the different linked problems.

chrisduerr avatar Nov 15 '18 09:11 chrisduerr

I have explored the issues you referenced, and while I have yet to try the commit #1778 fix, I want to illustrate this:

The left window is iTerm, the right is Alacritty. Both are managed by a window manager and thus should be the same size (if both indeed have no borders). However, iTerm, which has true borderless support, is clearly 1px smaller in size.

If I make Alacritty fully transparent, this discrepancy is more obvious, as you can see the border and shadow added by macOS.

screen shot 2018-11-15 at 7 47 20 am

Furthermore, the bordering is really strange when full transparency is introduced. I have been able to achieve no border will full transparency at either the cost of ghosting, or really strange border placement.

screen shot 2018-11-15 at 7 39 53 am screen shot 2018-11-15 at 7 50 19 am screen shot 2018-11-15 at 7 55 16 am You'll notice in the third and fourth image the presence of a randomly placed small box with a slight shadow. This is the same border that is generally wrapped around Alacritty when not in this error state. I was able to get different behavior depending on whether or not I had a background image or a solid color, as well as whether or not a new instance is spawned. I also occasionally get different behavior depending on the level of transparency.

badfilms avatar Nov 15 '18 13:11 badfilms

I am able to consistently reproduce the border in the 3rd image (the one surrounding my prompt). This is with a default alacritty.yml with two edits: decorations: none and background_opacity: 0.0.

Of note: The strange border placement is only when the window is focused.

badfilms avatar Nov 15 '18 13:11 badfilms

I am having similar issues with opacity, regardless of the decorations settings:

Screenshot 2024-04-03 at 16 45 12 Screenshot 2024-04-03 at 16 44 47 Screenshot 2024-04-03 at 16 44 17

0x4D5352 avatar Apr 11 '24 21:04 0x4D5352