Sejil icon indicating copy to clipboard operation
Sejil copied to clipboard

Making the settings configurable

Open ZvonimirMatic opened this issue 2 years ago • 1 comments

I think the settings could be more configurable. I don't see the reason for only one constructor with required parameters. In my opinion most of the properties should be able to be set publicly with some default values. This would allow for appsettings.json configuration. Also it would be very useful to be able to control certain parameters such as SqliteDbPath.

The interface ISejilSettings seems unnecessary.

If you want I can help you with the changes, but I would like your opinion first.

Other than that, it' a great library you've built!

ZvonimirMatic avatar Sep 13 '23 10:09 ZvonimirMatic

I started working on it, but I can't build the Client application. Tried npm install - got an error so tried npm install --force, but then running npm run build breaks with th following error:

> [email protected] build
> react-app-rewired build

node:internal/modules/cjs/loader:535
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/tokenize' is not defined by "exports" in C:\projects\Sejil\src\Sejil.Client\node_modules\postcss-safe-parser\node_modules\postcss\package.json
    at new NodeError (node:internal/errors:393:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:358:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:668:3)
    at resolveExports (node:internal/modules/cjs/loader:529:36)
    at Module._findPath (node:internal/modules/cjs/loader:569:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:981:27)
    at Module._load (node:internal/modules/cjs/loader:841:27)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (C:\projects\Sejil\src\Sejil.Client\node_modules\postcss-safe-parser\lib\safe-parser.js:1:17) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v18.12.1

ZvonimirMatic avatar Sep 13 '23 12:09 ZvonimirMatic