ParCool icon indicating copy to clipboard operation
ParCool copied to clipboard

[1.16.5 Compat Bug] Using Controllable to crawl causes walking speed instead of crawling speed

Open Kaleidio opened this issue 2 years ago • 4 comments

Summary Issue is in the title. Does not have the same issue with M/KB

Running Environment

  • Minecraft Version: 1.16.5
  • ParCool Version: 2.1.0.0-R
  • Forge Version (optional): 36.2.39

Description This issue is arising because controllable spams inputs that are held, rather than having an available held state to read from. Consider implementing a custom flag check instead of relying on the input classes isHeld method.

More than likely present on all available versions

Kaleidio avatar Feb 05 '23 16:02 Kaleidio

Issue serves as extension to https://github.com/alRex-U/ParCool/issues/129 and is not a duplicate

Kaleidio avatar Feb 05 '23 17:02 Kaleidio

Thanks for reporting.

Probably I should make "controller" tag for issues

alRex-U avatar Feb 06 '23 22:02 alRex-U

Now this is one of the most hardest obstacle to release Controllable support. Even if integrate crawl keybind and controller button as KeyBinding the bahavior are different depending which key pressed.

Internally actually ClientPlayerEntity.isMovingSlowly() returns true in both case, in fact, but only the input from keyboard works correctly.

In addition Controllable should have been implemented like it activate right, left, up, down keybindings when players knock sticks of a controller. Roll not work

alRex-U avatar Apr 29 '23 07:04 alRex-U