Al Liu
Al Liu
Hi, is the warning still there in the latest version? I test it on the my local machine, it seems that no warnings anymore.
> I still see the warnings on the latest version and is making CI fail. Which OS are you using? In `fs4`'s [CI](https://github.com/al8n/fs4-rs/actions/runs/13479714738), there are no warnings. Maybe using `FileExt::lock_*`...
> Is there anything that can be done to move this forward? I guess this could be a breaking change, but crossbeam is < 1.0 anyway - I've been thinking...
> It seems that @cuviper has tried something similar to this before ([indexmap-rs/indexmap#253 (comment)](https://github.com/indexmap-rs/indexmap/issues/253#issuecomment-1459160166)). The approach there does not seem to have type inference issues unlike this PR? (or am...
> Nice! Could you revert the turbofish addition on crossbeam-skiplist/tests/map.rs and crossbeam-skiplist/tests/set.rs as well? > > https://github.com/crossbeam-rs/crossbeam/pull/1132/files#diff-75f4f67227e1c745e030de5d756b0cc4cb11ccd273aac4bd1cf8277d4c7abc30 https://github.com/crossbeam-rs/crossbeam/pull/1132/files#diff-83acf27b3801996150152093e109e25ebe594f6595ead4c9297986b1d0a3ec27 Finished.
> LGTM. Could I merge this PR?
> I think such a change is a breaking change when done after this change is released. See [tokio-rs/bytes#479 (comment)](https://github.com/tokio-rs/bytes/issues/479#issuecomment-1011065884) for more. Actually, I am fine with keeping `Comparable` and...
> This is available via [`AsyncReadExt::shutdown`](https://docs.rs/tokio/latest/tokio/io/trait.AsyncWriteExt.html#method.shutdown). Yes, but the `shutdown` method in `AsyncWriteExt` requires the `&mut self`, which is not compatible with `std::net::TcpStream::shutdown(&self, how)`.
> Well, it certainly can't be `From`. I would be open to a `impl TryFrom for Regex` though, since that's consistent with existing `TryFrom` and `TryFrom` impls. > > I...
> That isn't a compelling enough motivation on its own IMO. That impl would require `regex` to always internally have an `Arc`, and this may not always be true. Indeed,...