jhop icon indicating copy to clipboard operation
jhop copied to clipboard

Routes implementation

Open romanyx opened this issue 6 years ago • 3 comments

https://github.com/cooldrip/jhop/issues/4

romanyx avatar May 03 '18 08:05 romanyx

Codecov Report

Merging #5 into master will decrease coverage by 10.81%. The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
- Coverage     100%   89.18%   -10.82%     
===========================================
  Files           1        1               
  Lines          26       37       +11     
===========================================
+ Hits           26       33        +7     
- Misses          0        4        +4
Impacted Files Coverage Δ
handler.go 89.18% <87.5%> (-10.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bca7a8c...76cc2de. Read the comment docs.

codecov-io avatar May 03 '18 08:05 codecov-io

it doesn't work with "{}/{id}": "{}/{id}/show" right? 'cause you're depending on routes.json as user defines the exact routes he/she wants to map a custom route to. am I right?

al3rez avatar May 05 '18 14:05 al3rez

Yes, you're right

romanyx avatar May 05 '18 14:05 romanyx