akvo-rsr icon indicating copy to clipboard operation
akvo-rsr copied to clipboard

Published 20 hours ago • verified publisher icon akvo

[#5161] Fix whitescreen when attempting a negative value for dsg

Open ifirmawan opened this issue 2 years ago • 1 comments

TODO / Done

Summarize what has been changed / what has to be done in order to finalize the PR.

  • [x] Set isNaN validation on disaggregations

Manual Test plan

What tests are necessary to ensure this works or doesn't break anything working

  • [ ] Add a negative value for a disaggregated indicator
  • [ ] Add a negative value for a unit indicator.
  • [ ] Add a negative value for a percentage indicator.

Add a negative value for a disaggregated indicator

Go to Total Impact / Jibu project

a4a_whitescreen

ifirmawan avatar Dec 12 '22 02:12 ifirmawan

Coverage Status

Coverage remained the same at 68.664% when pulling 2c36015613e6b07dc8c21172600a1c278ade9c65 on 5161-feature-request-reporting-on-negative-percentages into f30677d6c2005f6fc507c69cbf60a7b0aa3bc6df on production.

coveralls avatar Dec 12 '22 03:12 coveralls

Recreated the issue in production and tested the branch locally. Can confirm that this PR fixes the issue :+1: Merging the PR and then deploying

MichaelAkvo avatar Dec 12 '22 10:12 MichaelAkvo