akvo-rsr icon indicating copy to clipboard operation
akvo-rsr copied to clipboard

[#5080] Added active state to fix indicator approval workflow

Open ifirmawan opened this issue 2 years ago • 2 comments

TODO / Done

Summarize what has been changed / what has to be done in order to finalize the PR.

  • [x] Update status description.
  • [x] Add new icon history.
  • [x] Create audit trail modal
  • [x] Call /indicator_period_data_framework/ by period

Test plan

What tests are necessary to ensure this works or doesn't break anything working

  • [ ] View history at reporting period

View history at reporting period

  • Login with the MnE account
  • Go to project id : 9604.
  • Move to the results admin tab.
  • Find active indicators and click the clock history icon.

  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • https://app.asana.com/0/0/1204610468150266
    • https://app.asana.com/0/0/1204682486804306

ifirmawan avatar Aug 23 '22 16:08 ifirmawan

Coverage Status

Coverage remained the same at 66.732% when pulling 05192657812a188289cdc29bcd4c9fb30a11a81f on 5080-feature-request-nuffic-indicator-approval-workflow into c9d073b6e317f64a5207faa2102aaec6629c1fa8 on master.

coveralls avatar Aug 24 '22 12:08 coveralls

Adding link to #5080 for Zenhub

MichaelAkvo avatar Nov 09 '22 14:11 MichaelAkvo