react-native-ui-kitten
react-native-ui-kitten copied to clipboard
Remove defaultProps from MeasureElement component
Please read and mark the following check list before creating a pull request:
- [X] I read and followed the CONTRIBUTING.md guide.
- [X] I read and followed the New Feature Checklist guide.
Short description of what this resolves:
Resolves https://github.com/akveo/react-native-ui-kitten/issues/1813
Please review this, the error is really annoying and it will destroy the library in future
@greenfrvr, Are you still involved with this repo?
@elupanov
Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.
Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.
MeasureElement is the only function component I could find using defaultProps. The others are class components.
@greenfrvr please merge this one, as defaultProps in class components are still acceptable to use for now.
I've posted a workaround to fix this one and #1782 until this PR is approved
@greenfrvr, can you merge this and release a new version?
bump, this should be an easy fix boys
Looks like UI Kitten is dead.
Too bad... it's one of the best UI libraries out there i think.
+1 @greenfrvr
@KostyaDanovsky @elupanov @malashkevich @lugovsky @SashaSkywalker @greenfrvr @sashaqred @Tibing @32penkin @mmfKupl
Can anyone merge this or confirm UI Kitten is officially dead?
+1
contributors are still on Christmas vacation, it seems