react-native-ui-kitten icon indicating copy to clipboard operation
react-native-ui-kitten copied to clipboard

Remove defaultProps from MeasureElement component

Open rklomp opened this issue 1 year ago • 15 comments
trafficstars

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Resolves https://github.com/akveo/react-native-ui-kitten/issues/1813

rklomp avatar May 24 '24 11:05 rklomp

Please review this, the error is really annoying and it will destroy the library in future

Atsukoro1 avatar May 28 '24 14:05 Atsukoro1

@greenfrvr, Are you still involved with this repo?

rklomp avatar May 31 '24 15:05 rklomp

@elupanov

rklomp avatar Jun 19 '24 17:06 rklomp

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

greenfrvr avatar Jun 20 '24 07:06 greenfrvr

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

MeasureElement is the only function component I could find using defaultProps. The others are class components.

rklomp avatar Jun 20 '24 08:06 rklomp

@greenfrvr please merge this one, as defaultProps in class components are still acceptable to use for now.

vilnytskyi avatar Jun 22 '24 17:06 vilnytskyi

I've posted a workaround to fix this one and #1782 until this PR is approved

vilnytskyi avatar Jun 25 '24 18:06 vilnytskyi

@greenfrvr, can you merge this and release a new version?

rklomp avatar Jul 21 '24 09:07 rklomp

bump, this should be an easy fix boys

felixsebastian avatar Aug 10 '24 16:08 felixsebastian

Looks like UI Kitten is dead.

rklomp avatar Aug 10 '24 16:08 rklomp

Too bad... it's one of the best UI libraries out there i think.

dragospeta avatar Aug 10 '24 16:08 dragospeta

+1 @greenfrvr

ckeating99 avatar Aug 23 '24 21:08 ckeating99

@KostyaDanovsky @elupanov @malashkevich @lugovsky @SashaSkywalker @greenfrvr @sashaqred @Tibing @32penkin @mmfKupl

Can anyone merge this or confirm UI Kitten is officially dead?

rklomp avatar Aug 25 '24 11:08 rklomp

+1

evansendra avatar Nov 27 '24 23:11 evansendra

contributors are still on Christmas vacation, it seems

hidayatullahap avatar Dec 26 '24 00:12 hidayatullahap