react-native-ui-kitten icon indicating copy to clipboard operation
react-native-ui-kitten copied to clipboard

Fix for issues #1782 & #1767

Open psegalen opened this issue 1 year ago • 3 comments

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Issue #1767 is about modal flickering, it is caused by assigning decimal dimensions on modals, the fix just adds a Math.round() to width and height for Frames.

Issue #1782 is about a crash happening only on iOS when UI Kitten tries to measure a node that RN did not find, Android seems to support it but it makes an iOS app crash.

psegalen avatar Nov 07 '23 16:11 psegalen

I think it fixes #1751 so it may be taken for a duplicate of #1752 but it fixes 2 issues in one PR

psegalen avatar Nov 07 '23 16:11 psegalen

Hi. Is there a release, or planned release soon to fix the measureInWindow issue please

https://github.com/facebook/react-native/issues/41730

robpearmain avatar Jan 25 '24 13:01 robpearmain

@psegalen See my comment at https://github.com/akveo/react-native-ui-kitten/issues/1767 and https://github.com/akveo/react-native-ui-kitten/issues/1802

I had to use Math.floor() to fix my issue instead of Math.round().

rklomp avatar Feb 06 '24 17:02 rklomp